Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed an issue with drag and dropping items onto .py files #13986

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Fix: Fixed an issue with drag and dropping items onto .py files #13986

merged 6 commits into from
Nov 23, 2023

Conversation

antonioseet
Copy link
Contributor

@antonioseet antonioseet commented Nov 20, 2023 •
edited by yaira2
Loading

Allow for python files to be treated as executable files in order to allow dragging and dropping other files onto them.
Two main things changed were adding python to the executable files list, and not allowing for python files to be ran through Launcher.LaunchFileAsync() because when it does, it does not pass in the parameter, and returns true. Which means it will not run Win32Helpers.InvokeWin32ComponentAsync(), which runs the python file witht he proper path parameter.

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Unable to drag and drop any file onto .py files #13890

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Navigate to a folder with a python file
    3. Drag and drop a file onto the python file to verify it executes with the path of the dragged file as the parameter

Screenshots (optional)
Add screenshots here.

image
image

@yaira2 yaira2 changed the title Fix: being unable to drag and drop any file onto .py files #13890 Fix: Fixed an issue with drag and dropping items onto .py files Nov 21, 2023
@yaira2 yaira2 requested a review from 0x5bfa November 22, 2023 21:34
yaira2
yaira2 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 23, 2023
@yaira2 yaira2 merged commit c0bb1b8 into files-community:main Nov 23, 2023
6 checks passed
yaira2 added a commit to ferrariofilippo/Files that referenced this pull request Nov 23, 2023
@yaira2
Squashed commit of the following:
5043b3c 
commit 432b47c
Author: Yair <[email protected]>
Date:   Thu Nov 23 14:04:12 2023 -0500

    Update FUNDING.yml

commit f42f2ea
Author: Yair <[email protected]>
Date:   Thu Nov 23 10:01:39 2023 -0500

    Preview: 3.0.11

commit dfc7c2f
Author: Yair <[email protected]>
Date:   Thu Nov 23 10:00:16 2023 -0500

    Fix: Fixed check for admin (files-community#13971)

commit 79d31e3
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Nov 23 09:52:34 2023 -0500

    Build(deps): Bump SQLitePCLRaw.bundle_green from 2.1.6 to 2.1.7 (files-community#14029)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit c0bb1b8
Author: Tony Barrera <[email protected]>
Date:   Wed Nov 22 18:53:53 2023 -0800

    Fix: Fixed an issue with drag and dropping items onto .py files (files-community#13986)

commit 4b58c2d
Author: Yair <[email protected]>
Date:   Wed Nov 22 17:12:09 2023 -0500

    Fix: Disable media preview for archive items (files-community#14021)

commit 00543d8
Author: Yair <[email protected]>
Date:   Wed Nov 22 16:34:25 2023 -0500

    Feature: Indicate "Always keep on device" status (files-community#14012)

commit 92c5231
Author: Yair <[email protected]>
Date:   Wed Nov 22 14:01:23 2023 -0500

    New Crowdin updates (files-community#14022)

commit b3c4d83
Author: 0x5bfa <[email protected]>
Date:   Thu Nov 23 00:18:41 2023 +0900

    Code Quality: Renamed layout page classes to improve readability (files-community#13958)

commit 1e1bbe7
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Nov 22 09:50:51 2023 -0500

    Build(deps): Bump Microsoft.CodeAnalysis.CSharp from 4.5.0 to 4.8.0 (files-community#14017)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 5adae99
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Nov 22 09:50:36 2023 -0500

    Build(deps): Bump Microsoft.Graphics.Win2D from 1.1.0 to 1.1.1 (files-community#14016)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 8e974c7
Author: Yair <[email protected]>
Date:   Tue Nov 21 21:39:12 2023 -0500

    Feature: Display error when failing to calculate the hash of open files (files-community#14014)

commit bf7b5da
Author: Yair <[email protected]>
Date:   Tue Nov 21 21:18:46 2023 -0500

    Fix: Fixed NullReferenceException in GetCompressDestination (files-community#14007)

commit 79855ba
Author: Yair <[email protected]>
Date:   Tue Nov 21 17:36:37 2023 -0500

    Fix: Fixed xamlRoot in the ConsentDialog (files-community#14013)

commit 494153c
Author: William-Hiatt <[email protected]>
Date:   Tue Nov 21 13:17:49 2023 -0800

    Fix: Fixed "Drive Unplugged" error when compressing items in Column layout (files-community#13695)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@0x5bfa 0x5bfa Awaiting requested review from 0x5bfa

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Unable to drag and drop any file onto .py files
3 participants
@antonioseet @yaira2 @0x5bfa